Mark readers and writers as sending
#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
reviewed
Sep 15, 2025
| public consuming func collect<Result>( | ||
| upTo limit: Int, | ||
| body: (Span<Underlying.ReadElement>) async throws -> Result | ||
| body: consuming @escaping (Span<Underlying.ReadElement>) async throws -> Result |
Contributor
There was a problem hiding this comment.
This shouldn’t be escaping. Why is this needed?
Collaborator
Author
There was a problem hiding this comment.
Oh because I had marked the closure as consuming and I cannot do that unless it's also @escaping. However I don't think we need the closure to be consuming - this was a leftover of other stuff I was trying.
FranzBusch
reviewed
Sep 15, 2025
|
|
||
|
|
||
| extension Optional { | ||
| public mutating func sendingTake() -> sending Self { |
Contributor
There was a problem hiding this comment.
This shouldn’t be public
FranzBusch
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.