Add a ServerProtocol
#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/HTTPServer/HTTPServer.swift # Conflicts: # Sources/Example/Example.swift # Conflicts: # Sources/HTTPServer/HTTPServer.swift
FranzBusch
approved these changes
Nov 11, 2025
Comment on lines
8
to
11
| associatedtype ConcludingRequestReader: ConcludingAsyncReader & ~Copyable | ||
| associatedtype ConcludingResponseWriter: ConcludingAsyncWriter & ~Copyable | ||
|
|
||
| associatedtype RequestHandler: HTTPServerRequestHandler |
Contributor
There was a problem hiding this comment.
Can we add docs to those associated types?
Collaborator
Author
There was a problem hiding this comment.
I have added docs to associated types, but on second thought, I really don't think we need the readers and writers on the server protocol. We don't use them anywhere. Correct me if I'm wrong but we should get the same functionality just having the request handler as an associated type, and the associated types for readers and writers only on the handler.
FranzBusch
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.