Skip to content

Set up CI #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gjcairo merged 5 commits into from
Aug 6, 2025
Merged

Set up CI #8

gjcairo merged 5 commits into from
Aug 6, 2025

Conversation

@gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Aug 5, 2025

No description provided.

FranzBusch
FranzBusch reviewed Aug 5, 2025
View reviewed changes
.github/workflows/main.yml
name: Unit tests
uses: apple/swift-nio/.github/workflows/unit_tests.yml@main
with:
linux_5_10_enabled: false
Copy link
Contributor

@FranzBusch FranzBusch Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we disable 6_1 as well?

Copy link
Collaborator Author

@gjcairo gjcairo Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yes right now we should actually. I was thinking that we may be able to support 6.1 if we don't use Span in the API, but this should be disabled as of now.

Copy link
Collaborator Author

@gjcairo gjcairo Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also 6_0

@gjcairo
Copy link
Collaborator Author

gjcairo commented Aug 5, 2025

Hmm, I'm getting some errors: workflows are not allowed to be used in swift-server/swift-http-server. Reusable workflows in this workflow must be: within a repository owned by swift-server.. It's complaining because the workflow files are under apple/swift-nio and swiftlang/github-workflows. Not sure if there's some config magic that has to happen elsewhere?

@FranzBusch
Copy link
Contributor

FranzBusch commented Aug 5, 2025

God damn. Yes this is a problem since we are not on an enterprise plan and we cannot whitelist those workflows from other orgs

@gjcairo gjcairo added the semver/none No version bump required. label Aug 6, 2025
@gjcairo gjcairo requested a review from FranzBusch August 6, 2025 09:33
@gjcairo
Copy link
Collaborator Author

gjcairo commented Aug 6, 2025 •
edited
Loading

Okay things seem to be running now. Most of the failures are because availability annotations are missing and/or Sendability issues. I'll open a follow-up PR.

@gjcairo gjcairo merged commit 335d55f into main Aug 6, 2025
10 of 21 checks passed
@gjcairo gjcairo deleted the setup-ci branch August 6, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FranzBusch FranzBusch FranzBusch approved these changes

Assignees

No one assigned

Labels

semver/none No version bump required.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gjcairo @FranzBusch