Add missing availability annotations #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
reviewed
Aug 6, 2025
FranzBusch
reviewed
Aug 6, 2025
| func intercept( | ||
| input: Input, | ||
| next: (NextInput) async throws -> Void | ||
| next: @Sendable (NextInput) async throws -> Void |
Contributor
There was a problem hiding this comment.
Why? I am not sure that this is the right annotation for those APIs. There is no guarantee that the next method is callable concurrently
FranzBusch
reviewed
Aug 6, 2025
Sources/Middleware/Middleware.swift
Outdated
| func intercept( | ||
| input: Input, | ||
| next: (NextInput) async throws -> Void | ||
| next: @Sendable (NextInput) async throws -> Void |
Contributor
There was a problem hiding this comment.
Same here. I think this is a potential mistake. Maybe sending is okay here but not sure about @Sendable
This reverts commit 9932e76.
FranzBusch
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing availability annotations after removing platform requirements from the package manifest.
It also re-enables missing availability warnings in Xcode (which had been turned off). This was hiding a Sendability issue for some reason, but I'll fix that up in a follow-up PR since it's quite complex.