Skip to content

Conversation

@MaxDesiatov
Copy link
Contributor

Also cleaned up incorrect "SDK" naming: we're using Swift SDKs and not plain Clang or Xcode SDKs in these workflows.

Additionally "static SDK" is very non-specific, Swift SDKs for Wasm are also static, as we currently don't support dynamic linking on that platform. We should fully specify it as "Static Linux", same as in https://www.swift.org/documentation/articles/static-linux-getting-started.html

@MaxDesiatov MaxDesiatov requested a review from a team as a code owner August 4, 2025 13:38
MaxDesiatov referenced this pull request Aug 4, 2025
* Add workflows for Linux static SDK and Wasm SDK builds

* Update URLs and remove extra PR testing to prepare for merge
Copy link
Contributor

@jrflat jrflat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the SDK terminology and adding embedded support! Left some comments on logs that could also be updated from just "static SDK" but looks good.

Just to clarify, the _wasm-embedded SDK is included in the _wasm.artifactbundle.tar.gz that's installed, right? Also, do we want to add a job that tests the embedded build in swift_package_test.yml and pull_request.yml?

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Aug 4, 2025

Thanks for fixing the SDK terminology and adding embedded support! Left some comments on logs that could also be updated from just "static SDK" but looks good.

Thanks!

Just to clarify, the _wasm-embedded SDK is included in the _wasm.artifactbundle.tar.gz that's installed, right?

Yes.

Also, do we want to add a job that tests the embedded build in swift_package_test.yml and pull_request.yml?

Those will be changed in follow up PRs, as I don't see a way for a workflow change PR to refer to a script using absolute URL changed in the same PR. Before merging we need it to refer to main and PR branch is not main.

@MaxDesiatov MaxDesiatov requested a review from jrflat August 4, 2025 16:53
Copy link
Contributor

@jrflat jrflat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@shahmishal shahmishal merged commit 6065185 into swiftlang:main Aug 5, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants