Skip to content

When splitting lines for the cross-PR checkout also split on \r\n#249

Merged
ahoppen merged 1 commit intoswiftlang:mainfrom
ahoppen:cross-pr-line-split
Mar 26, 2026
Merged

When splitting lines for the cross-PR checkout also split on \r\n#249
ahoppen merged 1 commit intoswiftlang:mainfrom
ahoppen:cross-pr-line-split

Conversation

@ahoppen
Copy link
Member

@ahoppen ahoppen commented Mar 24, 2026

It seems like GitHub sometime in the last year started representing newlines in the PR description using \r\n instead of \n. Respect those as well to split the description into lines and find the linked PR indicator.

For now, a workaround is to put Linked PR: in the first line of the PR description.

It seems like GitHub sometime in the last year started representing newlines in the PR description using \r\n instead of \n. Respect those as well to split the description into lines and find the linked PR indicator.
@ahoppen ahoppen requested a review from a team as a code owner March 24, 2026 07:58
@ahoppen ahoppen merged commit 5867741 into swiftlang:main Mar 26, 2026
281 of 282 checks passed
@ahoppen ahoppen deleted the cross-pr-line-split branch March 26, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants