🍒[TSan] Fix deadlocks during TSan error reporting on Apple platforms #11303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible (llvm#151120) This is the refactoring portion of: llvm#149516. My aim is for this change to replicate current behaviour - just with Symbolization done explicitly (and later than previously). This change will enable us to perform symboliaztion after releasing the locks in `OutputReport`; this is necessary on Apple platforms in order to avoid a deadlock. (cherry picked from commit 26f9166)
…lvm#151495) Changes: Apple only: * Move OutputReport (and thus symbolization) after the locked region when reporting. * ScopedReportBase constructor requires the thread_registry lock to be held, so the regions where ScopedReports get created must be inside the locked region. * Bail early from MemoryAccess if we are symbolizing. Other platforms should behave as before, outputting reports while the locks are held. This is a follow up to llvm#151120, which delayed symbolization of ScopedReports. rdar://152829396 (cherry picked from commit cb1f1a7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reviewed:
rdar://152829396