[lldb] Pass execution context to CompilerType::GetByteSize - in CommandObjectMemoryRead (NFC) #11379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndObjectMemoryRead (NFC) Some type systems require an execution context be available when working with types (ex: Swift). This fixes `memory read --type` to support such type systems, by passing in an execution context to `GetByteSize()`, instead of passing null. rdar://158968545 (cherry picked from commit b574e63)
|
@swift-ci test |
|
@swift-ci test |
|
the test failures are existing rebranch issues. |
|
@swift-ci test macOS |
kastiglione
deleted the
dl/lldb-Pass-execution-context-to-CompilerType-GetByteSize-in-CommandObjectMemoryRead-NFC
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some type systems require an execution context be available when working with types
(ex: Swift). This fixes
memory read --typeto support such type systems, by passing inan execution context to
GetByteSize(), instead of passing null.rdar://158968545
(cherry picked from commit b574e63)