[dsymutil] Remove spurious exit when falling back to fat64 header #11958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vm#171189) In llvm#118898 I changed dsymutil to emit a warning instead of an error when exceeding the 4GB limit for a slice and automatically fall back to using the fat64 header. However, while doing so, I forgot to remove the return which defeats the whole purpose. rdar://140998416 (cherry picked from commit 83fd2c9)
Author
|
@swift-ci test |
adrian-prantl
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In llvm#118898 I changed dsymutil to emit a warning instead of an error when exceeding the 4GB limit for a slice and automatically fall back to using the fat64 header. However, while doing so, I forgot to remove the return which defeats the whole purpose.
rdar://140998416
(cherry picked from commit 83fd2c9)