Support: add workaround for newer MSVC toolchains #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MSVC toolchain implemented a resolution to DR1734, which results in `llvm::is_trivially_copyable` to not match with `std::is_trivially_copyable`. This is the minimal change that will match the ABI and allow building LLVM with a newer MSVC toolchain.
Member
Author
|
@swift-ci please test |
Member
Author
|
CC: @hyp Discussing a fix for upstream with Richard, it seems that the solution there is going to be far more invasive and not one that we will want to backport. The small change here (and associated changes in the runtime) seem like a better choice for Swift at the moment. |
Member
Author
|
@swift-ci please test macOS platform |
1 similar comment
Member
Author
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSVC toolchain implemented a resolution to DR1734, which results in
llvm::is_trivially_copyableto not match withstd::is_trivially_copyable. This is the minimal change that willmatch the ABI and allow building LLVM with a newer MSVC toolchain.