Fix issue that causes type hierarchy to not work for clang files #2264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang’s `textDocument/symbolInfo` request does not return a `kind` field. We were thus filtering all symbols from clang, which left us with no USR that could be used for the type hierarchy.
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
Member
Author
|
@swift-ci Please test |
bnbarham
reviewed
Aug 28, 2025
Comment on lines
+2470
to
+2471
| // Consider a symbol a class if its kind is `nil`, eg. for a symbol returned by clang's SymbolInfo, which | ||
| // doesn't support the `kind` field. |
Contributor
There was a problem hiding this comment.
Should it 🤔? This is our extension isn't it? I'm fine with this change regardless, since we still filter from the index.
Member
Author
There was a problem hiding this comment.
Yeah, would probably be nice if we added the kind field to the clangd request.
bnbarham
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang’s
textDocument/symbolInforequest does not return akindfield. We were thus filtering all symbols from clang, which left us with no USR that could be used for the type hierarchy.