Ensure the string passed to PathIsRelativeW is null terminated
#2361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
Contributor
Author
|
@swift-ci please test |
compnerd
approved these changes
Nov 19, 2025
bnbarham
force-pushed
the
flakey-compdb
branch
from
d63075c to
ec3edab
Compare
Contributor
Author
|
@swift-ci please test |
Member
|
@swift-ci Please test Windows |
bnbarham
force-pushed
the
flakey-compdb
branch
from
ec3edab to
45c3af7
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows |
1 similar comment
Contributor
Author
|
@swift-ci please test Windows |
`CompilationDatabaseTests` have been flakey on Windows since swiftlang#2334. This didn't really introduce the failure though - it just added tests that now catch it. The underlying cause is that `filename.isAbsolutePath` sometimes returns `true` for a relative path, which then causes the CWD to be prepended instead of the given `compileCommandsDirectory`. `PathIsRelativeW` requires a null terminated string, so presumably we were hitting junk after the initial path that sometimes turned it into an absolute path. From the Windows docs: > A pointer to a null-terminated string of maximum length MAX_PATH that contains the path to search. Fixes swiftlang#2360 Resolves rdar://165006835
bnbarham
force-pushed
the
flakey-compdb
branch
from
45c3af7 to
b3cb43f
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows |
1 similar comment
Contributor
Author
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompilationDatabaseTestshave been flakey on Windows since #2334. This didn't really introduce the failure though - it just added tests that now catch it.The underlying cause is that
filename.isAbsolutePathsometimes returnstruefor a relative path, which then causes the CWD to be prepended instead of the givencompileCommandsDirectory.PathIsRelativeWrequires a null terminated string, so presumably we were hitting junk after the initial path that sometimes turned it into an absolute path. From the Windows docs:Fixes #2360
Resolves rdar://165006835