-
Notifications
You must be signed in to change notification settings - Fork 125
Dump dependency information during the build #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump dependency information during the build #874
Conversation
|
@swift-ci please test |
Sources/SWBTaskExecution/TaskActions/ValidateDependenciesTaskAction.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to compare the dependency info format changes here. When the new setting is not enabled, will this produce the same output format as before?
This adds a new key I don't have a clear idea how the format should look like yet, so I was thinking to make additive changes like this at first and once we have a clearer picture, we could try to consolidate the existing structure if needed. |
659e5f5 to
8bc0ce1
Compare
|
@swift-ci please test |
- Extend `BuildDependencyInfo` with module/header dependencies - Extend `ValidateDependenciesTaskAction` to dump per target dependency information in the new format - The new behavior is opt-in behind a `DUMP_DEPENDENCIES` build setting
8bc0ce1 to
f594124
Compare
|
@swift-ci please test |
Actually, we won't need a version here, yet, since we don't serialize any dependencies as part of the existing command. The new format is only utilized for the output generated during the build. |
Since swiftlang#874, we are dumping per-target dependency information, this adds a new task which merges these for a given build request. The task is only created if there's at least one target in the graph that will dump dependency information, so should be a no-op for all builds right now. Additionally, this declares the dependency info file as an output of `ValidateDependencies` which I neglected to do in my earlier PR.
Since swiftlang#874, we are dumping per-target dependency information, this adds a new task which merges these for a given build request. The task is only created if there's at least one target in the graph that will dump dependency information, so should be a no-op for all builds right now. Additionally, this declares the dependency info file as an output of `ValidateDependencies` which I neglected to do in my earlier PR.
BuildDependencyInfowith module/header dependenciesValidateDependenciesTaskActionto dump per target dependency information in the new formatDUMP_DEPENDENCIESbuild setting