Skip to content

Conversation

@owenv
Copy link
Collaborator

@owenv owenv commented Nov 4, 2025

This is easiest to review one commit at a time. It's a series of refactors to fix some small correctness issues in target dependency resolution and make it more easily extensible as I get ready to integrate artifact bundle support.

  1. Ensure most clients are fetching settings for a target using the GlobalProductPlan instead of the BuildRequestContext + TargetDependencyGraph. This ensures imparted build properties and anything we add to the global product plan in the future are correctly taken into account
  2. Remove the unused CapturedBuildInfo mechanism, which relied on direct access to the TargetBuildGraph
  3. Fix some issues with how the symbol extraction support looked up dependency settings using the build graph
  4. Reduce some API surface of the TargetBuildGraph to encourage use of the GlobalProductPlan instead
  5. Refactor GlobalProductPlan into discrete mostly-functional passes to work towards improved parallelization, caching, and separation of responsibilities

@owenv
Copy link
Collaborator Author

owenv commented Nov 4, 2025

@swift-ci test

@owenv owenv force-pushed the owenv/targetresolution-refactors branch from ff3f8e3 to d8d92cc Compare November 4, 2025 23:44
@owenv
Copy link
Collaborator Author

owenv commented Nov 4, 2025

@swift-ci test

@owenv owenv force-pushed the owenv/targetresolution-refactors branch from d8d92cc to 65b901a Compare November 5, 2025 06:21
@owenv
Copy link
Collaborator Author

owenv commented Nov 5, 2025

@swift-ci test

@owenv
Copy link
Collaborator Author

owenv commented Nov 5, 2025

@swift-ci test

@owenv owenv merged commit d09d510 into swiftlang:main Nov 5, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants