Enable Dynamic library prefix #904
Closed
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhouri
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
Contributor
Author
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/enable_dynamic_library_executable_prefix
branch
from
fdb9ead to
feeeca8
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
I also started cross repository testing: |
owenv
approved these changes
Nov 11, 2025
Collaborator
owenv
left a comment
owenv
left a comment
There was a problem hiding this comment.
LGTM pending test results
| FULL_PRODUCT_NAME = "$(EXECUTABLE_NAME)"; | ||
| MACH_O_TYPE = "mh_dylib"; | ||
| REZ_EXECUTABLE = YES; | ||
| EXECUTABLE_PREFIX= "lib"; |
Collaborator
There was a problem hiding this comment.
nit: should be a leading space before the '='
jakepetroules
requested changes
Nov 11, 2025
Collaborator
jakepetroules
left a comment
jakepetroules
left a comment
There was a problem hiding this comment.
The following tests are failing on Linux:
- unitTestWithGeneratedEntryPoint
- unitTestWithGeneratedEntryPoint_testabilityDisabled
Contributor
Author
|
Closing in favour of swiftlang/swift-package-manager#9369. This changes in this PR will be submitted as part of #890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.