Skip to content

Conversation

@spevans
Copy link
Contributor

@spevans spevans commented Mar 14, 2019

  • DarwinCompatibility: TestStream.seek(to:) is internal API

  • DarwinCompatibility: Disable tests that use new API not yet in Foundation

  • Update Swift version to 5.0 and target deployment version to 10.14.

  • Rename TestNSProgressFraction.swift to TestProgressFraction.swift
    to reflect name of test class.

  • Wrap file in NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT as the type is
    internal and cant be tested by DarwinCompaitibilityTests.

  • Add TestPropertyListEncoder.swift and TestDateIntervalFormatter.swift
    to DarwinCompatibilityTests.

@spevans
Copy link
Contributor Author

spevans commented Mar 14, 2019

@swift-ci test

- Update Swift version to 5.0 and target deployment version to 10.14.

- Rename TestNSProgressFraction.swift to TestProgressFraction.swift
  to reflect name of test class.

- Wrap file in NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT as the type is
  internal and cant be tested by DarwinCompaitibilityTests.

- Add TestPropertyListEncoder.swift and TestDateIntervalFormatter.swift
  to DarwinCompatibilityTests.
@spevans spevans force-pushed the pr_darwin_compatibility_tests_2 branch from 04610ce to 2c27173 Compare March 15, 2019 13:29
@spevans
Copy link
Contributor Author

spevans commented Mar 15, 2019

@swift-ci test

2 similar comments
@spevans
Copy link
Contributor Author

spevans commented Mar 15, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Mar 15, 2019

@swift-ci test

@spevans spevans requested a review from millenomi March 15, 2019 20:58
@spevans
Copy link
Contributor Author

spevans commented Mar 24, 2019

@swift-ci test

3 similar comments
@spevans
Copy link
Contributor Author

spevans commented Mar 24, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Mar 24, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Mar 25, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Mar 26, 2019

@swift-ci test and merge

@swift-ci swift-ci merged commit 022c941 into swiftlang:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants