[6.3][cherrypick] Ensure strsep operates on a copy of PATH. (#5289) #5296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strsep modifies its first argument, which means that if we don't make a copy, any PATH processing that may occur after _CFProcessPath executes breaks because strsep will effectively change PATH to be only the first list item. For example, swiftpm's tool finding fails because it searches PATH, and if the tool in question doesn't reside in the first PATH item, things break. This only occurs on BSD and only when the program name, i.e., argv[0], is not an absolute path.
3405691582
changed the title
Member
Author
|
@swift-ci please test. |
parkera
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a PATH processing bug when the toolchain is installed on the BSDs.
Changes are scoped only to the BSDs, and the bug is only triggered when the program name, i.e., argv[0], is not an absolute or relative path.
No issues, but is of relevance to the OpenBSD port in swiftlang/swift#78437
#5289
Low, this is a bugfix and it is scoped only for the BSDs.
Original commit passed CI and original commit tested locally.
@parkera