Added underscores to gettid(void) to remove name clash #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovided gettid() in /usr/include/bits/unistd_ext.h that is not static
Member
|
@swift-ci please test |
Member
|
CC: @ktopley-apple |
ktopley-apple
suggested changes
Mar 20, 2019
Contributor
ktopley-apple
left a comment
ktopley-apple
left a comment
There was a problem hiding this comment.
I think you should use _gettid() instead of __gettid() to be more consistent with the existing naming conventions.
ktopley-apple
approved these changes
Mar 21, 2019
Contributor
|
@swift-ci please test |
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
Added underscores to gettid(void) to remove name clash Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with system-provided gettid() in /usr/include/bits/unistd_ext.h that is not static.
According to https://raw.githubusercontent.com/bminor/glibc/master/ChangeLog, Florian Weimer moved
units_ext.hfromsysdeps/generic/bitstobitsand libdispatch won't compile due to the function having different declarations between the system-provided one and the one defined inqueue.c.I figure that, since it's only being called in one spot in the same file, it was safe to rename the function in without having to make a special #ifdef Linux-only version.