dispatch_io pipe close test #476
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test macOS |
|
@swift-ci please test |
|
@weissi can you provide a patch that fixes this as well? |
|
@MadCoder @ktopley-apple this demonstrates a problem that we have been hitting on the linux pull request bots in c (so we can run it unconditionally in all the CI with/without swift). I don't know if it effects Darwin. |
ktopley-apple
approved these changes
May 3, 2019
It does not affect Darwin because the bug is in the way Dispatch uses |
Sorry, that fix isn't trivial and I really don't know enough about the dispatch implementation there. |
|
#477 is a tentative fix which makes this test pass. Thanks for providing this :) |
|
@compnerd cross repo PR testing only works cross repo ; ). |
gottesmm
pushed a commit
to gottesmm/swift-corelibs-libdispatch
that referenced
this pull request
May 6, 2019
If epoll_wait() reports EPOLLHUP, we must respond immediately and unregister the event or else Dispatch will go into a spinloop. This makes dispatch_io_pipe_close (swiftlang#476) pass on Linux with identical output to Darwin.
|
I created a combined PR for this with the fix. It is going through testing now. I am going to close this so there isn't confusion and we keep the record that it failed. The important part from the relevant log: |
weissi
pushed a commit
to weissi/swift-corelibs-libdispatch
that referenced
this pull request
May 14, 2019
If epoll_wait() reports EPOLLHUP, we must respond immediately and unregister the event or else Dispatch will go into a spinloop. This makes dispatch_io_pipe_close (swiftlang#476) pass on Linux with identical output to Darwin. (cherry picked from commit ffc7133)
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
If epoll_wait() reports EPOLLHUP, we must respond immediately and unregister the event or else Dispatch will go into a spinloop. This makes dispatch_io_pipe_close (#476) pass on Linux with identical output to Darwin. Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a test that documents the problem seen in