Combined PR: SR-9033 handle EPOLLHUP #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If epoll_wait() reports EPOLLHUP, we must respond immediately and unregister the event or else Dispatch will go into a spinloop. This makes dispatch_io_pipe_close (swiftlang#476) pass on Linux with identical output to Darwin.
|
@swift-ci test |
weissi
changed the title
weissi
approved these changes
May 6, 2019
There was a problem hiding this comment.
Thanks very much @adierking and @gottesmm ! This PR looks good to me!
|
We should also back-port this to the swift-5.0-branch branch |
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
Combined PR: SR-9033 handle EPOLLHUP Signed-off-by: Kim Topley <ktopley@apple.com>
This was referenced May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a combination of these two PRs combining authorship information:
#477
#476
As one can see #476 fails with ToT. Lets see if with 477 it passes and then lets land this sucker!