Implement XCTAssertIdentical & XCTAssertNotIdentical #325
Conversation
|
@swift-ci please test |
| // CHECK: test.swift:[[@LINE+3]]: error: FailureMessagesTestCase.testAssertNotIdentical : XCTAssertNotIdentical failed: \("nil"\) is identical to \("nil"\) - message | ||
| // CHECK: Test Case 'FailureMessagesTestCase.testAssertNotIdentical' failed \(\d+\.\d+ seconds\) | ||
| func testAssertNotIdentical() { | ||
| XCTAssertNotIdentical(nil, nil, "message", file: "test.swift") |
There was a problem hiding this comment.
Thank you for this change! I think we can land it soon
My only request is that you add a few more assertions to these two tests, in particular success cases which validate that both XCTAssertIdentical and XCTAssertNotIdentical succeed when passed identical or not identical values, respectively. Currently, the tests only validate failure scenarios, but we should be sure to have tests covering when they pass as well. Personally, I'm fine just adding those inside the existing two test method bodies, to keep things simple.
There was a problem hiding this comment.
Oh that's a good point. I added a few succeeding assertions to the test.
egorzhdan
force-pushed
the
XCTAssertIdentical
branch
from
3b83664 to
507bb91
Compare
|
@swift-ci please test |
| // CHECK: Test Case 'FailureMessagesTestCase.testAssertIdentical' failed \(\d+\.\d+ seconds\) | ||
| func testAssertIdentical() { | ||
| let object = XCTestExpectation() | ||
| XCTAssertIdentical(object as AnyObject, object as AnyObject) |
There was a problem hiding this comment.
Is it actually necessary to cast these using as AnyObject ? I would expect it to work without the casts
There was a problem hiding this comment.
With this specific assertion the cast wasn't needed indeed, I removed it.
All the other assertions require a cast to avoid a compiler error (type of expression is ambiguous without more context).
These functions are available in Xcode 12.5, but aren't available on Linux/Windows. This change adds the implementations for them.
egorzhdan
force-pushed
the
XCTAssertIdentical
branch
from
507bb91 to
cdda9d7
Compare
|
@swift-ci please test |
|
Looks great. Thank you! |
Implement XCTAssertIdentical & XCTAssertNotIdentical
3 participants
These functions are available in Xcode 12.5, but aren't available on Linux/Windows.
This change adds the implementations for them.