Remove default arguments from private functions #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since these are only ever called internally, these arguments should always be passed so it doesn't accidentally fall back to this file for expanding `#file` and friends.
Contributor
|
@swift-ci Please test |
stmontgomery
approved these changes
Sep 14, 2021
Contributor
stmontgomery
left a comment
stmontgomery
left a comment
There was a problem hiding this comment.
Good catch, thanks @keith !
keith
deleted the
ks/remove-default-arguments-from-private-functions
branch
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these are only ever called internally, these arguments should
always be passed so it doesn't accidentally fall back to this file for
expanding
#fileand friends.