Skip to content

Conversation

@shahmishal
Copy link
Member

The pipes module was removed in Python 3.13.

(cherry picked from commit 35b964c)

To unblock Fedora 41 CI. https://ci.swift.org/view/Swift%206.2/job/oss-swift-6.2-package-fedora-41/19/

The pipes module was removed in Python 3.13.

(cherry picked from commit 35b964c)
@shahmishal
Copy link
Member Author

@swift-ci test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work. shlex is not compatible with Windows and quotes command lines incorrectly.

(Ref: https://docs.python.org/3/library/shlex.html)

@shahmishal
Copy link
Member Author

@compnerd This has been part of main branch since July, are we actively seeing an issue? #510

@compnerd
Copy link
Member

compnerd commented Oct 1, 2025

Interesting - no, I don't think that I've seen an issue in the current usage, but I have definitely run into issues with shlex on Windows in the past and had to do work to remove it from the Swift repo's usage in the tests when I did the initial port.

@shahmishal
Copy link
Member Author

Going to merge this PR. If we see any issues, feel free to revert this patch.

@shahmishal shahmishal merged commit 3645483 into main Oct 1, 2025
2 checks passed
@shahmishal shahmishal deleted the 6.2-fedora-41 branch October 1, 2025 23:33
@da-viper
Copy link

da-viper commented Oct 3, 2025

@shahmishal could we cherry pick it into the 6.2.x branches as that is what is used in the fedora 6.2 ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants