Rename two internal targets for clarity #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
QuietMisdreavus
approved these changes
Nov 7, 2025
Contributor
QuietMisdreavus
left a comment
QuietMisdreavus
left a comment
There was a problem hiding this comment.
Looks good. I really appreciate the new names for these targets.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
Member
|
This appears to have caused a regression in CI: https://ci.swift.org/view/all/job/oss-swift-package-freebsd-14/226/ |
gottesmm
pushed a commit
that referenced
this pull request
Nov 10, 2025
This reverts commit d616aa5.
d-ronnqvist
added a commit
that referenced
this pull request
Nov 11, 2025
This reverts commit f2a841e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
This renames the
SwiftDocCUtilitiestarget toCommandLineand removes theSwiftDocCprefix fromSwiftDocCTestUtilities(simplifying it to onlyTestUtilities) to make the package organization a bit clearer, especially to new contributors.The
SwiftDocCUtilitiestarget was a bit confusingly named since it didn't contain utilities and was all about defining the command line actions and the preview server for the preview command.The prefix for the
SwiftDocCTestUtilitiestarget was just a bit redundant and IMO clearer—both in the package manifest and as an import—without it.Dependencies
None.
Testing
Nothing in particular. This isn't a user-facing change.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
[ ] Added tests./bin/testscript and it succeeded