Skip to content

Conversation

@mayaepps
Copy link
Contributor

Bug/issue #, if applicable: rdar://164440224

Summary

CodableContentSection is a public type that has an implicitly internal property called section. This change makes this property public, which allows other applications linking to Swift DocC to access it.

Dependencies

None.

Testing

Write a small Swift CLI executable program that links to the make-render-section-public branch of my Swift-DocC fork, and then test that you can access the property.

@main
struct CodableContentSectionTest {
    static func main() {
        print("Hello, world!")
        
        print(CodableContentSection(IntroRenderSection(title: "Title")).section)
    }
}

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests - N/A
  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary - N/A

This allows other applications linking to Swift DocC to access this property.
Copy link
Contributor

@patshaughnessy patshaughnessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - using @d-ronnqvist 's suggestion might be worthwhile also if you have time.

@mayaepps
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist
Copy link
Contributor

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit 9aabe36 into swiftlang:main Nov 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants