Skip to content

Make CodableContentSection.section property public #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2025
Merged

Make CodableContentSection.section property public #1344

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a9c6c5
Make CodableContentSection.section public
mayaepps Nov 10, 2025
8d7fcf5
Modernize how section property initializes its stored property using …
mayaepps Nov 12, 2025
2d9fbcf
Merge branch 'main' into make-render-section-public
d-ronnqvist Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Sources/SwiftDocC/Model/Rendering/RenderNode/CodableContentSection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ import Foundation
/// This allows decoding a ``RenderSection`` into its appropriate concrete type, based on the section's
/// ``RenderSection/kind``.
public struct CodableContentSection: Codable, Equatable {
var section: any RenderSection {
public var section: any RenderSection {
@storageRestrictions(initializes: typeErasedSection)
init(initialValue) {
typeErasedSection = AnyRenderSection(initialValue)
}
get {
typeErasedSection.value
}
Expand All @@ -27,15 +31,13 @@ public struct CodableContentSection: Codable, Equatable {

/// Creates a codable content section from the given section.
public init(_ section: any RenderSection) {
self.typeErasedSection = AnyRenderSection(section)
self.section = section
}

public init(from decoder: any Decoder) throws {
let container = try decoder.container(keyedBy: CodingKeys.self)
let kind = try container.decode(RenderSectionKind.self, forKey: .kind)

self.typeErasedSection = AnyRenderSection(ContentRenderSection(kind: .content, content: []))
switch kind {
case .discussion:
section = try ContentRenderSection(from: decoder)
Expand Down