Validate Darwin deployment targets and target variants #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Driver/os-deployment.swift
Contributor
Author
|
@swift-ci test |
DougGregor
approved these changes
Jul 19, 2020
Member
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
Part of me wonders whether this should be folded in to -print-target-info to have the frontend tell us the minimum supported version, but that can happen later. This improves things until then, thank you!
| // Check minimum supported OS versions. | ||
| if targetTriple.isMacOSX, | ||
| targetTriple.version(for: .macOS) < Triple.Version(10, 9, 0) { | ||
| throw ToolchainValidationError.osVersionBelowMinimumDeploymentTarget("OS X 10.9") |
Member
There was a problem hiding this comment.
What's this "OS X" thing? :) We should switch to macOS both here and in the integrated driver
Contributor
Author
There was a problem hiding this comment.
👍 , this error message could definitely use an update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Driver/os-deployment.swift and slightly improves Driver/macabi-environment.swift. There's some remaining Darwin-specific argument validation left to be implemented, which I'll create a starter bug for