Fix build on Windows #200
Fix build on Windows #200
Conversation
|
Updated this PR, now it depends on the changes in swiftlang/swift-tools-support-core#106. |
| let encoder = JSONEncoder() | ||
|
|
||
| #if os(Linux) || os(Android) | ||
| #if !canImport(ObjectiveC) |
There was a problem hiding this comment.
Why does withoutEscapingSlashes require ObjectiveC?
There was a problem hiding this comment.
When this was written, withoutEscapingSlashes wasn't implemented in corelibs-foundation yet. It looks like it's since been added in swiftlang/swift-corelibs-foundation@c3fd6ec, so I think this conditional block can be removed entirely.
There was a problem hiding this comment.
Thanks @owenv, turns out I was building with an outdated Foundation.
I'll drop that commit to keep the PR focused on Windows-related things.
|
@swift-ci please test |
|
@egorzhdan would you mind removing the SQLite3 dependency? That's not a true dependency for this project AFAICT, and its better to fix that in t-s-c rather than add that dependency here. (Or did I miss the import of SQLite in this project?) |
SwiftPM depends on SwiftDriver and SwiftOptions DLLs, so they should be installed into the toolchain bin directory
|
@compnerd ok, removed it. |
|
CC: @DougGregor |
|
lgtm, @DougGregor to approve |
|
LGTM, thank you! |
7 participants
SwiftDrivertarget importsTSCUtility(which has a dependency onTSCBasic) but only linked againstTSCBasicSwiftDriver.dll&SwiftOptions.dll, so they should be installed into the toolchain bin directorystrsignalis not available