Add github workflow to test PR in github actions #2006
Conversation
Add github actions for swift-driver tests that uses swiftlang/github-workflows.
|
@swift-ci please test |
|
GitHub Actions is not enabled yet on this repo, once it's enabled we can take this change. |
|
This would definitely help us get better Windows coverage! |
Is there anything needs to be discussed to turn on GitHub action? |
| linux_swift_versions: '["nightly-main", "nightly-6.2"]' | ||
| windows_swift_versions: '["nightly-main"]' | ||
| windows_build_command: 'Invoke-Program swift test' | ||
| enable_linux_static_sdk_build: true |
There was a problem hiding this comment.
Can you also add:
enable_android_sdk_build: true
enable_ios_checks: true
There was a problem hiding this comment.
What does that do? We don't have swift driver test case that target those that requires android SDK or iOS sdk. Swift-driver tests are mostly standalone with only execution environment difference.
I did file this: #1828 which might just as well be a separate task in matrix?
There was a problem hiding this comment.
I'm not sure that we should be enabling that - Android is meant to be supported as a host platform not a build platform (i.e. you wouldn't really run the driver on Android, only the generated binaries).
There was a problem hiding this comment.
What does that do? We don't have swift driver test case that target those that requires android SDK or iOS sdk. Swift-driver tests are mostly standalone with only execution environment difference.
I did file this: #1828 which might just as well be a separate task in matrix?
Swift Build builds for iOS and Android and depends on Swift driver, I want to avoid regressions getting into the build early.
I'm not sure that we should be enabling that - Android is meant to be supported as a host platform not a build platform (i.e. you wouldn't really run the driver on Android, only the generated binaries).
Some people are using Android as a host.
There was a problem hiding this comment.
I would suggest have a different set of action to test swift-build. Feel free to add the current list.
Like I said, the build side of the test does not need any SDK. All swift-driver tests need to be standalone without relying on any SDK, and the test case recreates SDK structure if needed.
We never added android Host support for running swift-driver. We need to make sure that works and there is a reason for it to work, before committing resources to it.
|
GitHub Actions is enabled, I was hopping it would trigger after reopening the PR. |
|
@swift-ci please test windows platform |
I assume it will only run action from the repo, otherwise I can just PR with an updated bad action to pass all tests/run malicious code. |
|
@swift-ci please test windows platform |
|
Sadly, the first commit is never tested, this is a long standing annoyance with GHA. But subsequent changes should get tested. |
|
@cachemeifyoucan can you create a branch on this repo? we have fork actions disabled. |
|
Also |
|
|
@swift-ci please test windows platform |
4 participants
Add github actions for swift-driver tests that uses swiftlang/github-workflows.