[Explicit Module Builds] Re-scan all clang modules against all targets against which they will be built. #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
VersionedClangModuleScanning
branch
from
c5f02fd to
afbdf8d
Compare
Contributor
Author
|
In the original PR I'd forgotten to add the new file to the CMakeLists.txt. And our CI builds using SwiftPM so it didn't catch that. :( |
Contributor
Author
|
@swift-ci please test |
artemcm
force-pushed
the
VersionedClangModuleScanning
branch
from
afbdf8d to
9b38515
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
…s against which they will be built. - Factor out placeholder dependency resolution out of the ExplicitModuleHandler into the Driver - Generate and post-process the dependency graph before passing it on to the ExplicitModuleHandler: - Run the Swift Fast Dependency Scanner. - Resolve placeholder dependencies, if any. - Re-scan and update Clang modules with a super-set of their dependencies against all compilation targets.
artemcm
force-pushed
the
VersionedClangModuleScanning
branch
from
9b38515 to
0d7e6d1
Compare
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
Author
|
@swift-ci please test |
DougGregor
approved these changes
Aug 21, 2020
owenv
approved these changes
Aug 23, 2020
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally merged in #214, reverted in #216.