Properly resolve paths to temporary response files when autolinking #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
owenv
force-pushed
the
response-file-path-resolution
branch
from
42fe7c3 to
7912ad3
Compare
Contributor
Author
|
@swift-ci test |
artemcm
approved these changes
Aug 24, 2020
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, .autolink files were passed as flags throughout the driver so that they could be prefixed by "@". This PR adds a new Job.ArgTemplateKind,
responseFilePathto make sure we resolve the underlying path properly. This fixes most of the Driver/tools_directory integration test (there's at least one other remaining unrelated issue preventing it from passing)