[Explicit Module Builds] Point module dependency modules to be put into the module cache #238
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the module cache Preprocess the dependency graph, setting module paths to be relative to the module cache path, if one is present. Only do so for modules that do not already provide a path.
Contributor
Author
|
One alternative I considered was to have the job generation code set the output paths, but that approach is not sufficient, because we also use the dependency graphs to communicate existence and location of module dependencies (for placeholder resolution), for which we would need to encode this information into the dependency graph anyway. |
Contributor
Author
|
@swift-ci please test |
nkcsgexi
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preprocess the dependency graph, setting module paths to be relative to the module cache path, if one is present.
Only do so for modules that do not already specify a path.