Implement additional argument validation steps and record multiple failures before exiting #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
DougGregor
approved these changes
Sep 6, 2020
Member
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
This looks great! Thank you
Contributor
Author
|
Looks like I made a small mistake with the original implementation - a couple of these diagnostics should be warnings. Thanks for the quick review @DougGregor! |
Contributor
Author
|
@swift-ci test |
JhonnyBillM
approved these changes
Sep 6, 2020
| import XCTest | ||
| import SwiftDriver | ||
| import TSCBasic | ||
| import TSCUtility |
Contributor
Author
There was a problem hiding this comment.
Not right now, but we might need it to import Diagnostics.fatalError when we address the main.swift FIXME. For now I've dropped it.
… diagnostics from errors to warnings
owenv
force-pushed
the
more-validation
branch
from
5b73779 to
c21e733
Compare
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation for:
-profile-generateand-profile-use-Fand-FsystemAdditionally, if a validation step fails when initializing the driver, don't fail immediately. Instead, record any other validation failures and then exit before planning.