build: link Yams privately #244
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Yams is used with `@_implementationOnly`, the clients of `SwiftDriver` do not need to link against `Yams` or `CYaml`. This was uncovered when building SourceKit-LSP.
Member
Author
|
@swift-ci please test |
DougGregor
approved these changes
Sep 7, 2020
Member
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
Great. I really want the default to be @_inplementationOnly in the language
fengjixuchui
referenced
this pull request
in fengjixuchui/swift-driver
Sep 7, 2020
Merge pull request apple#244 from compnerd/yams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Yams is used with
@_implementationOnly, the clients ofSwiftDriverdo not need to link againstYamsorCYaml. This wasuncovered when building SourceKit-LSP.