-
Notifications
You must be signed in to change notification settings - Fork 216
Install swift-help for integration tests. Suppress .noDriver options from being emitted by swift-help. #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
owenv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@swift-ci test |
owenv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
…from being emitted by swift-help. Fixes: Driver/help.swift
e694866 to
c761312
Compare
|
@owenv |
|
Okay, found 3 categories of Definitely checked for and used: Technically supported, sets the compiler output type to pch, but I don't know if it actually works: Erased when |
|
Okay, actually I have to do a bit more digging here. C++ driver claims these are unsupported, so swift-driver probably should too This happens for all these parameters. First I'm going to find where this check happens in the c++ driver, then I'm going to look at the unit tests we have that are using these parameters. |
|
Okay, I've updated the driver to emit an Re-requesting reviews since the diff has changed quite a bit. Also I need someone to kick off CI :) |
|
@swift-ci please test |
owenv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm surprised this many options were affected, the C++ driver definitely has some dead code that's checking for these...
Fixes: Driver/help.swift
Also replaces deprecated
createSymlinkcalls withlocalFileSystem.createSymbolicLink