[Incremental] Allow build record to reside at a relative path #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Part of rdar://71869992 (Swift Driver must handle relative paths in build records and other places in order to support legacy Driver/Dependencies tests) |
artemcm
reviewed
Dec 3, 2020
| } | ||
| } | ||
|
|
||
| extension VirtualPath { |
Contributor
There was a problem hiding this comment.
We already have:
extension VirtualPath {
fileprivate func resolvedRelativePath(base: AbsolutePath) -> VirtualPath {
guard case let .relative(relPath) = self else { return self }
return .absolute(.init(base, relPath))
}
}
In OutputFileMap.swift. Should we common these two out?
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this! Will do!!
artemcm
approved these changes
Dec 3, 2020
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow build record to reside at a relative path on the way to making legacy lit tests work.
rdar://71869992