[Incremental] Honor -driver-always-rebuild-dependents #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
artemcm
approved these changes
Dec 8, 2020
artemcm
reviewed
Dec 8, 2020
| case .needsCascadingBuild: | ||
| switch (status, alwaysRebuildDependents) { | ||
|
|
||
| case (_, true): |
Contributor
There was a problem hiding this comment.
Can we add a test that exercises the (.upToDate, true) to ensure this is not regressed in the future?
Contributor
Author
There was a problem hiding this comment.
One of the legacy lit tests already does so; that's how I found the issue. But, let me see if I can add an XC test.
Contributor
Author
|
@swift-ci please test |
Contributor
|
Thank you, @davidungar! |
davidungar
force-pushed
the
honor-always-rebuild-deps
branch
from
66f1641 to
ada2f1c
Compare
Contributor
Author
|
@swift-ci please test |
davidungar
force-pushed
the
honor-always-rebuild-deps
branch
from
ada2f1c to
b3c309f
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Fixes rdar://72157018 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to pass legacy tests, honor -driver-always-rebuild-dependents