Skip to content

Revert "[Incremental] Enable testBatchModeContinueAfterErrors & skip frontend query even if no extra arguments to -driver-use-frontend-path" #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artemcm merged 1 commit into from
Dec 8, 2020
Merged

Revert "[Incremental] Enable testBatchModeContinueAfterErrors & skip frontend query even if no extra arguments to -driver-use-frontend-path" #403

artemcm merged 1 commit into from
Dec 8, 2020

Conversation

@artemcm
Copy link
Contributor

@artemcm artemcm commented Dec 8, 2020

Reverts #393

This change causes a failure in SwiftPM unit-tests:

Test Case '-[BuildTests.BuildPlanTests testExplicitSwiftPackageBuild]' started.
/Volumes/Data/GHWorkspace1/swift-driver/Sources/SwiftDriver/Execution/DriverExecutor.swift:91: error: -[BuildTests.BuildPlanTests testExplicitSwiftPackageBuild] : failed: caught error: "jobFailedWithNonzeroExitCode(1, "<unknown>:0: error: unsupported target architecture: \'\'\n<unknown>:0: error: unsupported target OS: \'\'\n")"
Test Case '-[BuildTests.BuildPlanTests testExplicitSwiftPackageBuild]' failed (0.208 seconds).

@artemcm
Revert "[Incremental] Enable testBatchModeContinueAfterErrors & skip …
98a7c59 
…frontend query even if no extra arguments to -driver-use-frontend-path"
@artemcm artemcm requested a review from davidungar December 8, 2020 20:24
@artemcm
Copy link
Contributor Author

artemcm commented Dec 8, 2020

@swift-ci please test

@artemcm
Copy link
Contributor Author

artemcm commented Dec 8, 2020

Thanks, @DougGregor.

@artemcm artemcm merged commit aafcd93 into main Dec 8, 2020
@mattt mattt mentioned this pull request Dec 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DougGregor DougGregor DougGregor approved these changes

@davidungar davidungar Awaiting requested review from davidungar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artemcm @DougGregor