[Incremental] Another attempt to get the driver to honor -driver-use-frontend-path #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@artemcm What do you think about this approach? @DougGregor Do you want to weigh in? Is there a better alternative? |
artemcm
approved these changes
Dec 10, 2020
| swiftCompilerPrefixArgs = [] | ||
| } | ||
| var hasFrontendBeenRedirectedForTesting: Bool { | ||
| return !swiftCompilerPrefixArgs.isEmpty |
Contributor
There was a problem hiding this comment.
I find this to be quite confusing and the new approach is much more concrete so I think it is an improvement.
Contributor
Author
There was a problem hiding this comment.
Thank you, @artem. Glad you think it's better.
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one only subverts the frontend target check if the new frontend path is a Python script. That way, the option still should work with swiftpm. Don't merge until the swiftpm unit tests pass with this.