[Incremental] Improve the interface to DependencySource #490
Conversation
|
@swift-ci please test |
|
@swift-ci please test |
| var externalDependencyToCheck: ExternalDependency? { externalDependency } | ||
| var isIncremental: Bool { | ||
| fingerprint != nil && externalDependency.isSwiftModule | ||
| var incrementalDependencySourceIfPresent: DependencySource? { |
There was a problem hiding this comment.
The ifPresent suffix here is already communicated by the type. https://swift.org/documentation/api-design-guidelines/#promote-clear-usage
There was a problem hiding this comment.
Please document the conditions where this returns nil since it's not just a matter of presence, right? If there aren't any fingerprints, you'll bail here with nil.
| try? fileSystem.getFileInfo(file).modTime | ||
| } | ||
|
|
||
| var swiftModuleFileIfPresent: TypedVirtualPath? { |
| var isIncremental: Bool { | ||
| fingerprint != nil && externalDependency.isSwiftModule | ||
| var incrementalDependencySourceIfPresent: DependencySource? { | ||
| guard let _ = fingerprint, |
There was a problem hiding this comment.
| guard let _ = fingerprint, | |
| guard fingerprint != nil, |
There was a problem hiding this comment.
Happy to remove the ifPresent's. I was on the fence anyway. Wrt let _ = ..., I'm inclined to leave it in. That idiom is used a tad more frequently in this code than the != nil.
CodaFi
left a comment
CodaFi
left a comment
There was a problem hiding this comment.
Just a few nits. Nothing to block things.
|
@swift-ci please test |
|
Thanks! |
2 participants
Deal with erroneous file types a bit better.