[Incremental] Handle nodes imported from swiftmodules #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
cltnschlosser
approved these changes
Feb 13, 2021
| // swiftmodules won't be in the map | ||
| graph.inputDependencySourceMap.contains(key: $0) | ||
| ? "\(node.key) in \(graph.inputDependencySourceMap[$0].file.basename)" | ||
| : "\(node.key)" |
Contributor
There was a problem hiding this comment.
if let won't be one line but it will prevent need to query the map twice
Contributor
Author
There was a problem hiding this comment.
Interesting... I always thought that ?: used short-circuit evaluation. I'll have to try that out. Thanks for taking a look.
Contributor
Author
There was a problem hiding this comment.
Indeed, according to a hasty experiment, I think that ?: does short-circuit.
Contributor
Author
There was a problem hiding this comment.
But, now I see what you mean. Sorry--there's an odd aspect to this map; unlike normal maps, it crashes if subscripted with an absent key. We plan to fix that in a later PR.
Contributor
Author
There was a problem hiding this comment.
At least this isn't in code that normally runs.
CodaFi
approved these changes
Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to keep
printPathfrom crashes when nodes are integrated from swiftmodules, when we start doing cross-module dependencies.