Reduce with inout #587
Merged
Reduce with inout #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proposals/XXXX-reduce-with-inout.md
Outdated
| @@ -0,0 +1,94 @@ | |||
| # Feature name | |||
chriseidhof
commented
Jan 24, 2017
Contributor
Author
chriseidhof
left a comment
chriseidhof
left a comment
There was a problem hiding this comment.
I think this is ready for review!
proposals/XXXX-reduce-with-inout.md
Outdated
| @@ -0,0 +1,94 @@ | |||
| # Feature name | |||
Contributor
|
Replacing existing In other words, while I welcome a mutating reduce, I'm against keeping two versions of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening the PR so that the proposal can already be commented on. There is still an active discussion going on about the naming, but the rest is pretty clear and agreed upon.