[6.0] Add FoundationNetworking hook for reading contents of remote URL #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
itingliu
approved these changes
Aug 6, 2024
This was referenced Aug 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Adds a hook point for FoundationNetworking to allow
Data(contentsOf:)to perform a remote URL request to fetch dataScope: Should only impact calling
Data(contentsOf:)with a non-file URL, turning an error into non-regressed behavior (but is inert without the matching SCL-F change)Original PR: #820
Risk: Minimal - fixes a regression where the current behavior is just to
throw, and fairly limited scopeTesting: Testing done via swift-ci testing and local testing
Reviewer: @iCharlesHu