-
Notifications
You must be signed in to change notification settings - Fork 50
WiX: Add _TestingInterop #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This includes the library created in swiftlang/swift-testing#1369 Resolves rdar://163673609
| <File Source="$(PlatformRoot)\Developer\Library\Testing-$(ProductVersion)\usr\lib\swift\windows\aarch64\_Testing_WinSDK.lib" /> | ||
| </Component> | ||
| <Component Directory="Testing_usr_lib_swift_windows_arm64" DiskId="2"> | ||
| <File Source="$(PlatformRoot)\Developer\Library\Testing-$(ProductVersion)\usr\lib\swift\windows\aarch64\_TestingInterop.lib" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm admittedly just copying similar examples already here, so I wanted to call this part out. The .lib in my Windows toolchain seems to be static libs:
jerryjrchen@JJC-WINDOWS:/mnt/c/Users/jerryjrchen/AppData/Local/Programs/Swift/Platforms/0.0.0$ file ./Windows.platform/Developer/Library/Testing-0.0.0/usr/lib/swift/windows/aarch64/Testing.lib
./Windows.platform/Developer/Library/Testing-0.0.0/usr/lib/swift/windows/aarch64/Testing.lib: current ar archive
I assume this means we support building both statically and dynamically linked test bundles (binaries?) on Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows exposes library content differently than you're used to. Let's sync up later today and I'll try to share what little I know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look correct. Please do a cross-repo toolchain build before merging.
The lib files are import libraries (conceptually like a tbd) and the DLL are the runtime bits (conceptually like a dylib).
|
Confirmed the libraries are in the right locations with a toolchain install: |
This includes the library created in swiftlang/swift-testing#1369
Will move out of draft once I build the toolchain and confirm it works as expected.
Resolves rdar://163673609