Skip to content

IfConfigDecl support broke Android builds #676

@madsodgaard

Description

@madsodgaard

Unfortunately, the PR #671 accidentally broke Android cross-compilation builds:

/Users/mads/dev/swift-chia/.build/checkouts/swift-java/Sources/JExtractSwiftLib/JExtractDefaultBuildConfiguration.swift:28:95: error: type 'StaticBuildConfiguration' has no member 'embedded'
 26 |     let decoder = JSONDecoder()
 27 |     do {
 28 |       base = try decoder.decode(StaticBuildConfiguration.self, from: StaticBuildConfiguration.embedded)
    |                                                                                               `- error: type 'StaticBuildConfiguration' has no member 'embedded'
 29 |     } catch {
 30 |       fatalError("Embedded StaticBuildConfiguration is broken! data: \(String(data: StaticBuildConfiguration.embedded, encoding: .utf8) ?? "")")

/Users/mads/dev/swift-chia/.build/checkouts/swift-java/Sources/JExtractSwiftLib/JExtractDefaultBuildConfiguration.swift:30:110: error: type 'StaticBuildConfiguration' has no member 'embedded'
 28 |       base = try decoder.decode(StaticBuildConfiguration.self, from: StaticBuildConfiguration.embedded)
 29 |     } catch {
 30 |       fatalError("Embedded StaticBuildConfiguration is broken! data: \(String(data: StaticBuildConfiguration.embedded, encoding: .utf8) ?? "")")
    |                                                                                                              `- error: type 'StaticBuildConfiguration' has no member 'embedded'
 31 |     }
 32 |   }

The same issue can also be seen in the CI for the PR (https://github.com/swiftlang/swift-java/actions/runs/24014202054/job/70036602977?pr=671), probably a mistake that it was merged anyway? 🤔

Could we revert the commit unless a fix is trivial and quicker?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions