[JExtract] Translate generic parameters #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
jextract-generic-parameters
branch
2 times, most recently
from
1a7df9e to
51b5ab6
Compare
ktoso
reviewed
Jul 30, 2025
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
very exciting, looking good! :-)
rintaro
force-pushed
the
jextract-generic-parameters
branch
from
024b932 to
131f09f
Compare
* Integrate `SwiftLexicalLookup` for unqualified type lookups * Introduce `SwiftTypeLookupContext` as a facade for `SwiftLexicalLookup` and a cached conversion from Syntax to `SwiftTypeDeclaration` instance. This wraps and replaces `SwiftSymbolTable`. * Introduce `SwiftGenericParameterDeclration` as a subclass of `SwiftTypeDeclaration` to represent generic parameters. * Store generic parameters and requirements in `SwiftFunctionSignature`. * `SwiftType.representativeConcreteTypeIn()` for getting `Data` from `T: DataProtocol` type.
rintaro
force-pushed
the
jextract-generic-parameters
branch
from
131f09f to
7fcdbe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limited generic parameter support in JExtract
SwiftLexicalLookupfor unqualified type lookups. This is required to find the generic parameter declaration from parameter types.SwiftTypeLookupContextas a facade forSwiftLexicalLookupand a cached conversion from Syntax toSwiftTypeDeclarationinstance. This wraps and replacesSwiftSymbolTable.SwiftGenericParameterDeclarationas a subclass ofSwiftTypeDeclarationto represent generic parameters.SwiftFunctionSignature.SwiftType.representativeConcreteTypeIn()for gettingDatafromT: DataProtocoltype.