Skip to content

Fix passed JExtractGenerationMode not being used by JExtractCommand. #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

Fix passed JExtractGenerationMode not being used by JExtractCommand. #404

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
606fbaa
Fix JExtractGenerationMode not being used by JExtractCommand.
pelekon Oct 19, 2025
6b92d32
Fix Samples tests.
pelekon Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/SwiftJavaTool/Commands/JExtractCommand.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ extension SwiftJava {
@OptionGroup var commonOptions: SwiftJava.CommonOptions

@Option(help: "The mode of generation to use for the output files. Used with jextract mode.")
var mode: JExtractGenerationMode = .ffm
var mode: JExtractGenerationMode?

@Option(help: "The name of the Swift module into which the resulting Swift types will be generated.")
var swiftModule: String
Expand Down Expand Up @@ -86,6 +86,11 @@ extension SwiftJava.JExtractCommand {
if let javaPackage {
config.javaPackage = javaPackage
}
if let mode {
config.mode = mode
} else if config.mode == nil {
config.mode = .ffm
}
config.swiftModule = self.effectiveSwiftModule
config.outputJavaDirectory = outputJava
config.outputSwiftDirectory = outputSwift
Expand Down