JavaMethod's need to handle type erasure; Enable Optional::get() -> T #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
resolves #439 |
ktoso
force-pushed
the
wip-generic-javakit-methods
branch
from
37deee3 to
33ed99e
Compare
ktoso
changed the title
ktoso
force-pushed
the
wip-generic-javakit-methods
branch
from
57c6c97 to
c440a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we support generics, we need to do special handling for
-> Tupcalls... since the T would be replaced with a real type with Swift, which then messes up the function signature we're looking for in the JVM.This works towards adjusting the
@JavaMethodmacro and then we have to adjust wrap-java to make use of that to "enable type erasure" when doing these calls.This is some first steps, hardcoding the Optional::get() and i'll adjust the generator next