Fix JNI symbols not exposed in release mode#650
Merged
ktoso merged 2 commits intoswiftlang:mainfrom Mar 29, 2026
Merged
Conversation
Contributor
Author
|
I've seen this problem compiling for Android with command: Then, command reveals that symbols have the small corresponding to internal symbols. |
Contributor
Author
|
This probably also solves issues #492 |
Collaborator
|
I'll fixup the tests, funnily enough I've hit the same issue just now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling swift-java in release mode, libSwiftJava.so does not expose JNI functions like
Java_org_swift_swiftkit_core_SwiftObjects_getRawDiscriminator.This PR makes public all methods generated with macro
JavaImplementation.