jextract/jni: support generic params : DataProtocol #669
Merged
ktoso merged 4 commits intoswiftlang:mainfrom Apr 1, 2026
Merged
jextract/jni: support generic params : DataProtocol #669ktoso merged 4 commits intoswiftlang:mainfrom
ktoso merged 4 commits intoswiftlang:mainfrom
Conversation
Functions with `<D: DataProtocol>` generic constraints failed to translate because `.foundationDataProtocol` and `.essentialsDataProtocol` fell through to the default case in `translateGenericTypeParameter`.
ktoso
commented
Apr 1, 2026
| secondswiftObject$ = secondpointer$Existential$ | ||
| return SwiftModule.verify(first: firstswiftObject$, second: secondswiftObject$).getJNILocalRefValue(in: environment) | ||
| } | ||
| """ |
Collaborator
Author
There was a problem hiding this comment.
On the other hand... man that's a lot of code for the chunk... I'll just take the imp[important bits maybe
ktoso
force-pushed
the
wip-jni-dataprotocol-generic-translation
branch
from
85244fd to
573b85e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions with
<D: DataProtocol>generic constraints failed to translate because.foundationDataProtocoland.essentialsDataProtocolfell through to the default case intranslateGenericTypeParameter.This uses the automatic existential opening in the thunks!
The test thunks outputs are a bit huge but I found it useful to have them visually tbh... Worst case if much changes we can change them to be less checking